Updated to Bootstrap 2.1 WIP and Multisite #1

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@tsanyqudsi
  • Switched from Bootstrap CSS to LESS
  • Added if multisite then load Blogs Menu instead of This Blog Menu
  • Normalization ( Github sez )
  • Added Submenu for Blogs Menu ( Still buggy .. i think it's from bootstrap )
tsanyqudsi added some commits Jul 30, 2012
@tsanyqudsi tsanyqudsi Updated to Bootstrap 2.1.0-WIP and Multisite
Remove CSS, Add Less and adding ManageBlogs instead of just This Blog if
Multisite
58bb3de
@tsanyqudsi tsanyqudsi Updating The Files 3bb8ad2
@tsanyqudsi tsanyqudsi Normalization 2294790
Owner

Thanks for this submission, but without an accompanying process for converting the site back to being production ready - collected and minified JS, and compiled LESS into CSS - I can't integrate it into the project I'm working on.

Its auto compiled. Dont worry... u can try it ur self by downloading my repo
On Jul 31, 2012 8:08 AM, "Aaron Collegeman" <
reply@reply.github.com>
wrote:

Thanks for this submission, but without an accompanying process for
converting the site back to being production ready - collected and minified
JS, and compiled LESS into CSS - I can't integrate it into the project I'm
working on.


Reply to this email directly or view it on GitHub:

#1 (comment)

Owner

You mean it's compiled at the client using the LESS JavaScript?

exactly.

2012/7/31 Aaron Collegeman <
reply@reply.github.com

You mean it's compiled at the client using the LESS JavaScript?


Reply to this email directly or view it on GitHub:

#1 (comment)

Owner

OK, so that's what I'm referring to by "production ready," which probably confused things.

I can't deploy naked less stylesheets to my live site - they must be compiled first back to CSS.

I have nothing in my deployment script to automate the compilation (which is the easy part), and there's no code in your WordPress template to detect runtime environment to use the compiled CSS instead of the LESS (which isn't hard, but still must be written).

Without those pieces, I can't merge this into my project.

sigh

<script src="/js/less-1.3.0.min.js" type="text/javascript"></script>

on fatpanda-buddypress/frame/parts/header.php line 35

using that script, the client would compiled the less to CSS :)

2012/7/31 Aaron Collegeman <
reply@reply.github.com

OK, so that's what I'm referring to by "production ready," which probably
confused things.

I can't deploy naked less stylesheets to my live site - they must be
compiled first back to CSS.

I have nothing in my deployment script to automate the compilation (which
is the easy part), and there's no code in your WordPress template to detect
runtime environment to use the compiled CSS instead of the LESS (which
isn't hard, but still must be written).

Without those pieces, I can't merge this into my project.


Reply to this email directly or view it on GitHub:

#1 (comment)

Owner

Sorry, I'm not doing a good enough job at explaining this.

  1. less.js is OK for development.
  2. less.js is NOT OK for live sites that clients use.

I appreciate that you're suggesting the LESS files could be used for development.

What I'm suggesting to you is that you find a way to make it possible to use LESS for dev, but transition automatically on deployment.

@collegeman collegeman closed this Jul 31, 2012

ah ok.. point taken.

It's my miss. Was thinkin "Production" means Development instead of Live
Site.. will put that in mind. :)

Thanks man

2012/7/31 Aaron Collegeman <
reply@reply.github.com

Sorry, I'm not doing a good enough job at explaining this.

  1. less.js is OK for development.
  2. less.js is NOT OK for live sites that clients use.

I appreciate that you're suggesting the LESS files could be used for
development.

What I'm suggesting to you is that you find a way to make it possible to
use LESS for dev, but transition automatically on deployment.


Reply to this email directly or view it on GitHub:

#1 (comment)

Owner

Yeah, sorry. I screwed that up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment