Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Updated to Bootstrap 2.1 WIP and Multisite #1

Closed
wants to merge 3 commits into from
+8,109 −7,621

2 participants

@tsanyqudsi
  • Switched from Bootstrap CSS to LESS
  • Added if multisite then load Blogs Menu instead of This Blog Menu
  • Normalization ( Github sez )
  • Added Submenu for Blogs Menu ( Still buggy .. i think it's from bootstrap )
tsanyqudsi added some commits
@tsanyqudsi tsanyqudsi Updated to Bootstrap 2.1.0-WIP and Multisite
Remove CSS, Add Less and adding ManageBlogs instead of just This Blog if
Multisite
58bb3de
@tsanyqudsi tsanyqudsi Updating The Files 3bb8ad2
@tsanyqudsi tsanyqudsi Normalization 2294790
@collegeman
Owner

Thanks for this submission, but without an accompanying process for converting the site back to being production ready - collected and minified JS, and compiled LESS into CSS - I can't integrate it into the project I'm working on.

@tsanyqudsi
@collegeman
Owner

You mean it's compiled at the client using the LESS JavaScript?

@tsanyqudsi
@collegeman
Owner

OK, so that's what I'm referring to by "production ready," which probably confused things.

I can't deploy naked less stylesheets to my live site - they must be compiled first back to CSS.

I have nothing in my deployment script to automate the compilation (which is the easy part), and there's no code in your WordPress template to detect runtime environment to use the compiled CSS instead of the LESS (which isn't hard, but still must be written).

Without those pieces, I can't merge this into my project.

@tsanyqudsi
@collegeman
Owner

Sorry, I'm not doing a good enough job at explaining this.

  1. less.js is OK for development.

  2. less.js is NOT OK for live sites that clients use.

I appreciate that you're suggesting the LESS files could be used for development.

What I'm suggesting to you is that you find a way to make it possible to use LESS for dev, but transition automatically on deployment.

@collegeman collegeman closed this
@tsanyqudsi
@collegeman
Owner

Yeah, sorry. I screwed that up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 30, 2012
  1. @tsanyqudsi

    Updated to Bootstrap 2.1.0-WIP and Multisite

    tsanyqudsi authored
    Remove CSS, Add Less and adding ManageBlogs instead of just This Blog if
    Multisite
  2. @tsanyqudsi

    Updating The Files

    tsanyqudsi authored
  3. @tsanyqudsi

    Normalization

    tsanyqudsi authored
Something went wrong with that request. Please try again.