Can't build a bot with a program passed as a string

[Anton-V-K]

When a bot built with a firmware loaded from external file its program doesn't start.

Script sample:

void object::buildBot(int type, string firmware_file)
{
	int nLines = 0;
	file hFile();
	hFile.open(firmware_file, "r");
	string firmware = "";
	while(not hFile.eof())
	{
		firmware += hFile.readln() + "\n";
		++nLines;
	}
	hFile.close();
	message(nLines + " lines were loaded from " + firmware_file);
	
	object it = radar(BotFactory);
	goto(it.position);
	drop();
	move(-2.5);
	it.factory(type, firmware);
}

I tried the sample Shooter script from the very basic solution: the program runs fine if it is included in the script of the building grabber (so the code is like it.factory(type, "Shooter"), and same program doesn't start if it is loaded into the new bot from an external file.
Code battle mode with version 0.1.9 (Windows 7 64-bit).

[melex750]

Be sure your program has an 'extern' function.

.factory(WingedShooter, "/files/Shooter.txt"); // files folder

 // public program folder
.factory(WingedShooter, "/program/Shooter.txt");

 // private program folder
.factory(WingedShooter, "/savegame/<PLAYER_NAME>/program/Shooter.txt");

It would be nice if there were shortcuts like:
"%priv%/Shooter.txt"
"%publ%/Shooter.txt"

It would good if %lvl%, %cat%, and %chap% work with .factory() too.

[Anton-V-K]

@melex750 , thanks for the help.
This way the bot's program gets started fine.
I wonder why the program doesn't run when it is passed directly. This bug makes it impossible to run auto-generated (or auto-modified) programs on created bots.

[melex750]

I can only think it might be a compile error or an error that stops the program.
This example works.

extern void object::Test()
{
	string prog = "extern void object::ProgramString()\n";
	prog += "{\n";
	prog += "    while(this.energyCell == null) wait(1);\n"; // wait for a battery
	prog += "    message(\"Hello World!\");\n";
	prog += "}\n";
	
	object botFactory = radar(BotFactory);
        botFactory.factory(WheeledGrabber, prog);
}

You can open the debugger during a code battle by:
Selecting the bot, click the camera mode button then the edit program button.
I usually pause the game first though.

[Anton-V-K]

@melex750 , thanks for looking into it.
You code works fine. And I also tried loading a smaller/simpler program from a file - it also works as expected.
So I guess something is wrong with my particular program, which is loaded into the bot ( I've attached it as
HuntFromAir.txt.zip ).
If I pass the path with the program directly into factory, it is loaded and works fine. However if I read the file into a string and then pass into factory, the program isn't loaded into the new bot (its programs list will be empty, except for a dummy New slot).
In the second case I also dump the program (after reading from file) back to disk to check its content - it is identical to the original program (except for an extra New Line character at the end).

[melex750]

I was able to reproduce this, it is basically a bug in Bot Factory code.
It's caused by line 29 of your HuntFromAir program.

If the string passed to.factory() contains .txt at the end of a line,
factory will try to use the entire string as a file path.
See line 413 autofactory.cpp.

[krzys-h]

@melex750 good catch, I didn't really realize that the string argument may contain more than one line :P