Dev boost filesystem removal #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to remove boost:filesystem from CResourceManager Move() function has to be removed or rewrited. Since Move is only used in autosave rotation it's simpler to change autosave rotation and remove Move(). Now oldest autosaves (with lowest timestamp) will be removed in rotation.
|
👍, looks good, I'll test this when I have some time |
| } | ||
|
|
||
| int CRobotMain::GetAutosaveSlots() | ||
| { | ||
| return m_autosaveSlots; | ||
| } | ||
|
|
||
| int CRobotMain::AutosaveRotate(bool freeOne) | ||
| // Remove oldest saves with autosave prefix | ||
| void CRobotMain::AutosaveRotate() |
There was a problem hiding this comment.
Removing the freeOne parameter broke behaviour of autosave rotation when changing amount of autosave slots in settings. Now when you adjust the number of slots, the AutosaveRotate function will remove one save too much (it assumes that a new save is going to be always created immediately after, which is not the case)
There was a problem hiding this comment.
I guess AutosaveRotate() call can be removed when setting slot number. This way it'll remain simple and it'll delete old saves on next autosave.
krzys-h
added a commit
that referenced
this pull request
Jun 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This pull request removes boost::filesystem from resource manager. Now boost::filesystem is only used before resource manager takes control. I did not touch CBot code and how files are handled there.
There's also small change to save naming.