Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new smart control module for finer control of coloring #10

Merged
merged 9 commits into from
Dec 18, 2016

Conversation

mackwic
Copy link
Collaborator

@mackwic mackwic commented Sep 25, 2016

TODO:

  • move the logic in its own module
  • detect if stdout_is_a_tty (removed: not smart enough and carry a dependance to libc)
  • detect windows platform
  • try to see if we can detect cygwin / mingw / cmder etc... (opt)
  • manual override (via global toggle flag)
  • manual override for block

Will make colored v2

@mackwic
Copy link
Collaborator Author

mackwic commented Sep 25, 2016

Note: I am in the process from decoupling env setup and control logic because env is too fragile. I think it's a bit overkill but well...

@mackwic mackwic force-pushed the feature-prog-force-color-mode branch from 8da305f to db1d99f Compare October 1, 2016 13:33
@mackwic mackwic force-pushed the feature-prog-force-color-mode branch from c4ad5d0 to 050d417 Compare December 1, 2016 13:29
@mackwic mackwic changed the title (break) Add new smart control module for finer control of coloring Add new smart control module for finer control of coloring Dec 18, 2016
@mackwic
Copy link
Collaborator Author

mackwic commented Dec 18, 2016

Seems good. Even better: it's non-breaking ! :)

@mackwic mackwic merged commit 46ea218 into master Dec 18, 2016
@mackwic mackwic deleted the feature-prog-force-color-mode branch December 18, 2016 21:47
danc86 pushed a commit to danc86/colored that referenced this pull request Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants