From 7e4d9ac8797c7bb44ab65e275314c79e3f6eb652 Mon Sep 17 00:00:00 2001
From: Thomas Mansencal <thomas.mansencal@gmail.com>
Date: Mon, 30 Aug 2021 23:15:26 +1200
Subject: [PATCH] Improve coverage of "colour.recovery" sub-package.

---
 colour/recovery/jakob2019.py              |  2 +-
 colour/recovery/tests/test_jakob2019.py   | 55 +++++++++++++++++++----
 colour/recovery/tests/test_mallett2019.py |  2 +-
 3 files changed, 48 insertions(+), 11 deletions(-)

diff --git a/colour/recovery/jakob2019.py b/colour/recovery/jakob2019.py
index d749bbace0..e3d0be5896 100644
--- a/colour/recovery/jakob2019.py
+++ b/colour/recovery/jakob2019.py
@@ -35,7 +35,7 @@
 
 if is_tqdm_installed():
     from tqdm import tqdm
-else:
+else:  # pragma: no cover
     from unittest import mock
 
     tqdm = mock.MagicMock()
diff --git a/colour/recovery/tests/test_jakob2019.py b/colour/recovery/tests/test_jakob2019.py
index f53e7cceca..2dd0f771fc 100644
--- a/colour/recovery/tests/test_jakob2019.py
+++ b/colour/recovery/tests/test_jakob2019.py
@@ -155,7 +155,7 @@ def test_XYZ_to_sd_Jakob2019(self):
             _recovered_sd, error = XYZ_to_sd_Jakob2019(
                 XYZ, self._cmfs, self._sd_D65, additional_data=True)
 
-            if error > JND_CIE1976 / 100:
+            if error > JND_CIE1976 / 100:  # pragma: no cover
                 self.fail('Delta E for \'{0}\' is {1}!'.format(name, error))
 
     def test_domain_range_scale_XYZ_to_sd_Jakob2019(self):
@@ -202,6 +202,13 @@ def setUp(self):
 
         self._temporary_directory = tempfile.mkdtemp()
 
+        self._LUT = LUT3D_Jakob2019()
+        self._LUT.generate(self._RGB_colourspace, self._cmfs, self._sd_D65, 5)
+
+        self._path = os.path.join(self._temporary_directory,
+                                  'Test_Jakob2019.coeff')
+        self._LUT.write(self._path)
+
     def tearDown(self):
         """
         After tests actions.
@@ -214,7 +221,7 @@ def test_required_attributes(self):
         Tests presence of required attributes.
         """
 
-        required_attributes = ('lightness_scale', 'coefficients', 'size',
+        required_attributes = ('size', 'lightness_scale', 'coefficients',
                                'interpolator')
 
         for attribute in required_attributes:
@@ -231,6 +238,33 @@ def test_required_methods(self):
         for method in required_methods:
             self.assertIn(method, dir(LUT3D_Jakob2019))
 
+    def test_size(self):
+        """
+        Tests :attr:`colour.recovery.jakob2019.LUT3D_Jakob2019.size` property.
+        """
+
+        self.assertEqual(self._LUT.size, 5)
+
+    def test_lightness_scale(self):
+        """
+        Tests :attr:`colour.recovery.jakob2019.LUT3D_Jakob2019.lightness_scale`
+        property.
+        """
+
+        np.testing.assert_almost_equal(
+            self._LUT.lightness_scale,
+            np.array(
+                [0.00000000, 0.06561279, 0.50000000, 0.93438721, 1.00000000]),
+            decimal=7)
+
+    def test_coefficients(self):
+        """
+        Tests :attr:`colour.recovery.jakob2019.LUT3D_Jakob2019.coefficients`
+        property.
+        """
+
+        self.assertTupleEqual(self._LUT.coefficients.shape, (3, 5, 5, 5, 3))
+
     def test_LUT3D_Jakob2019(self):
         """
         Tests the entirety of the
@@ -238,12 +272,7 @@ def test_LUT3D_Jakob2019(self):
         """
 
         LUT = LUT3D_Jakob2019()
-        LUT.generate(self._RGB_colourspace, self._cmfs, self._sd_D65, 5)
-
-        path = os.path.join(self._temporary_directory, 'Test_Jakob2019.coeff')
-
-        LUT.write(path)
-        LUT.read(path)
+        LUT.read(self._path)
 
         for RGB in [
                 np.array([1, 0, 0]),
@@ -265,10 +294,18 @@ def test_LUT3D_Jakob2019(self):
 
             error = delta_E_CIE1976(Lab, recovered_Lab)
 
-            if error > 2 * JND_CIE1976 / 100:
+            if error > 2 * JND_CIE1976 / 100:  # pragma: no cover
                 self.fail('Delta E for RGB={0} in colourspace {1} is {2}!'
                           .format(RGB, self._RGB_colourspace.name, error))
 
+    def test_raise_exception_read(self):
+        """
+        Tests :func:`colour.recovery.jakob2019.LUT3D_Jakob2019.read` method
+        raised exception.
+        """
+
+        self.assertRaises(ValueError, self._LUT.read, __file__)
+
 
 if __name__ == '__main__':
     unittest.main()
diff --git a/colour/recovery/tests/test_mallett2019.py b/colour/recovery/tests/test_mallett2019.py
index 38c0a3f089..90b0369fcb 100644
--- a/colour/recovery/tests/test_mallett2019.py
+++ b/colour/recovery/tests/test_mallett2019.py
@@ -84,7 +84,7 @@ def check_basis_functions(self):
 
             error = delta_E_CIE1976(Lab, recovered_Lab)
 
-            if error > 4 * JND_CIE1976 / 100:
+            if error > 4 * JND_CIE1976 / 100:  # pragma: no cover
                 self.fail('Delta E for "{0}" is {1}!'.format(name, error))