Skip to content

/colour

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing spaces in "colour.encoding_cctf" and "colour.decoding_cctf" definitions docstrings. #505

Closed
sobotka opened this issue Sep 30, 2019 · 4 comments

Comments

@sobotka
Copy link
Contributor

commented Sep 30, 2019

Missing a space after the the.

colour/colour/models/rgb/transfer_functions/__init__.py

Line 782 in 2bf80fe

'definition, please refer to the "colour.oetf" definition for the'

@KelSolaar

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 30, 2019

Good catch! Actually there is another one two lines above, there must be some other similar in the file.
@KelSolaar KelSolaar added this to the v0.3.14 milestone Sep 30, 2019
@KelSolaar

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 30, 2019 •
edited

@sobotka : Mind opening a PR for this one please whenever you have some cycles, should be very easy :) Careful at line length though, you might put some words on the next line, i.e. reformat the whole thing.
@KelSolaar KelSolaar changed the title Typo in output from REC.2100 EOTF Fix missing spaces in "colour.encoding_cctf" and ""colour.decoding_cctf" definitions docstrings. Sep 30, 2019
@sobotka

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 30, 2019

Will do! If you catch others, drop them here and I’ll do one squished commit.
@KelSolaar KelSolaar referenced this issue Oct 1, 2019
Open
@KelSolaar KelSolaar changed the title Fix missing spaces in "colour.encoding_cctf" and ""colour.decoding_cctf" definitions docstrings. Fix missing spaces in "colour.encoding_cctf" and "colour.decoding_cctf" definitions docstrings. Oct 1, 2019
@KelSolaar

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 1, 2019

Thanks @sobotka! I did not see any but I must admit I'm not actively chasing them, just taming them as I go usually.
pavithraes added a commit to pavithraes/colour that referenced this issue Oct 1, 2019
@pavithraes
Fix spaces as per colour-science#505
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
37d1765
pavithraes added a commit to pavithraes/colour that referenced this issue Oct 1, 2019
@pavithraes
fix spaces as per colour-science#505
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
4cc445f
pavithraes added a commit to pavithraes/colour that referenced this issue Oct 1, 2019
@pavithraes
Merge pull request #1 from pavithraes/hotfix/fix_spaces
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
f588d2d 
Fix spaces as per colour-science#505
@pavithraes pavithraes referenced this issue Oct 1, 2019
Merged
pavithraes added a commit to pavithraes/colour that referenced this issue Oct 2, 2019
@pavithraes
Fix missing spaces by wrapping lines (as per colour-science#505)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
dadbb5e
@KelSolaar KelSolaar closed this in 6609563 Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Documentation Good First Issue Hacktoberfest
Projects
None yet
Milestone
  v0.3.14
2 participants
@sobotka @KelSolaar
You can’t perform that action at this time.