Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Drop unittest usage in favour of pytest. #1266

Merged
merged 2 commits into from
May 19, 2024
Merged

Conversation

KelSolaar
Copy link
Member

Summary

This PR is a first initial pass at dropping unittest in favour of pytest with the intent of using parameterised tests with #1244.

I used a mix of pytestify and unittest2pytest to do most of the conversion and finished manually.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • [N/A] New transformations have been added to the Automatic Colour Conversion Graph.
  • [N/A] New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • [N/A] New features are documented along with examples if relevant.
  • [N/A] The documentation is Sphinx and numpydoc compliant.

@coveralls
Copy link

coveralls commented May 19, 2024

Coverage Status

coverage: 99.815% (-0.01%) from 99.829%
when pulling eff1ef2 on feature/pytest
into 7ecfb43 on develop.

@KelSolaar KelSolaar force-pushed the feature/pytest branch 5 times, most recently from 16a09bc to eff1ef2 Compare May 19, 2024 05:59
@KelSolaar KelSolaar merged commit fa01ef6 into develop May 19, 2024
29 of 30 checks passed
@KelSolaar KelSolaar deleted the feature/pytest branch May 19, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants