Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat source files as UTF-8 to avoid encoding errors #103

Merged
merged 1 commit into from Jan 27, 2012

Conversation

@joeyates
Copy link
Contributor

joeyates commented Jan 12, 2012

Avoid errors like this:
gems/simplecov-0.5.4/lib/simplecov/source_file.rb:158:in `block in process_skipped_lines!': invalid byte sequence in US-ASCII (ArgumentError)

A fixture file is included which contains a degree symbol. The line containing the symbol currently causes the above exception.

Avoid errors like this:
gems/simplecov-0.5.4/lib/simplecov/source_file.rb:158:in `block in process_skipped_lines!': invalid byte sequence in US-ASCII (ArgumentError)

A fixture file is included which contains a degree symbol. The line containing the symbol currently causes the above exception.
@xaviershay
Copy link
Collaborator

xaviershay commented Jan 14, 2012

I experienced this same error, and this patch fixed it. Spec looks good, I think it should be merged.

colszowka added a commit that referenced this pull request Jan 27, 2012
Treat source files as UTF-8 to avoid encoding errors
@colszowka colszowka merged commit 58045dd into colszowka:master Jan 27, 2012
@colszowka
Copy link
Owner

colszowka commented Jan 27, 2012

Great, thanks a lot!

@auxbuss auxbuss mentioned this pull request Feb 20, 2012
@colszowka
Copy link
Owner

colszowka commented Feb 22, 2012

New gem release 0.6.0 rolls out in a couple minutes

rlqualls pushed a commit to rlqualls/sugarcane that referenced this pull request Feb 1, 2014
I can't get a failing test case, though it is failing on one of our
projects and is the same bug and fix as that in simplecov:
colszowka/simplecov#103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.