Separate streaming and database streaming. Python 3-ify #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be a breaking change since it separates
text.streamers
fromtext.database_streamers
. The difference is that people can userosetta.text
without having to have database dependencies likepymongo
andMySQL-python
(the latter of which requires a mysql client dependency, which is kind of annoying to carry around if you aren't using mysql). This would partially address people's install issues (e.g. #48)The other changes are so that
rosetta
installs using intopython3
environments. There are a couple slightly dirty solutions here, implemented by catchingImportError
, but for the most partrosetta
is python3 compatible so it might as well work there.