Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Instance of String Error #53

Closed
mspacemedia opened this Issue · 2 comments

2 participants

@mspacemedia

When adding the Bulk editing tools for the comment module requirements the following error is displayed in the admin section:

GridFieldBulkManager::addBulkAction() must be an instance of string, string given, called in /public_html/comments/code/CommentAdmin.php on line 60

A quick fix was to change line 184 in GridFieldBulkManager.php from:

function addBulkAction( string $name, $label = null, $handler = null, $config = null)

to:

function addBulkAction($name, $label = null, $handler = null, $config = null)

It needs further testing but got the modules working together for me...

@colymba colymba closed this in 0e30789
@colymba
Owner

Yeah that's my bad, PHP doesn't actually allow type hinting for scalar. Depending on the environment, this causes error. All should be running fine now, thanks for spotting it!

@mspacemedia

No problem, glad to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.