#75 Fix cache cleanup + enable FLUSH_CACHE_ON_GC by default #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhendriks
changed the title
Member
|
I've updated the PR title. |
dhendriks
approved these changes
Aug 7, 2025
Contributor
Author
|
Perhaps a small side note still on this PR: cache cleanup now doesn't consider the 'instance' fields of saturation cache entries. This means that cache cleanup assumes that the transition relation BDDs used for saturation are not garbage collected. This is a reasonable assumption I think, but an assumpion nevertheless, that hasn't yet been made explicit somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75.
This PR also disables cache flushing by default. The JavaDoc of
FLUSH_CACHE_ON_GCsays "For most problems, you should keep this set to true.". On the other hand: in case JavaBDD is used for small problem instances, GC will not be invoked and the performance stays the same. And in case JavaBDD is used for large problem instances, GC will be invoked, and then we've seen performance improvements.