Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Range Pretty Print #337

Merged
merged 2 commits into from Feb 3, 2016
Merged

For Range Pretty Print #337

merged 2 commits into from Feb 3, 2016

Conversation

@Saheb
Copy link
Contributor

@Saheb Saheb commented Feb 2, 2016

Previously

@ 1 to 10
res3: collection.immutable.Range.Inclusive = Range(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)

By this change

@ 1 to 10
res4: Range.Inclusive = Range(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)
@lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Feb 2, 2016

@Saheb can you describe briefly, in english, what this change does and why it fixes what it seems to fix?

@Saheb
Copy link
Contributor Author

@Saheb Saheb commented Feb 2, 2016

@lihaoyi - I am new to refelction, was just playing around with symbols and types, and while tweeking, got this to work. Not sure with the resoning behind it. Trying to figure it out.

@lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Feb 3, 2016

Well let me know if you figure something out. It would be nice to know kinda-sorta why this works before merging it. Also, would be nice to have a unit test because CI is cheap and I'm not paying for it

I hear @paulp knows about the scala refelction API but he may be busy

image

@lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Feb 3, 2016

Also, if you're fast, this can go out with #338 and the "fix" for #199 in the next release

@lihaoyi lihaoyi merged commit 040e021 into com-lihaoyi:master Feb 3, 2016
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
lihaoyi pushed a commit that referenced this pull request Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants