Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed resolver pattern for local ivy #395

Merged
merged 1 commit into from Jun 2, 2016
Merged

Conversation

@aishfenton
Copy link

@aishfenton aishfenton commented May 30, 2016

Addresses this bug: #300

Problem is that locally published jars in Ivy have a different pattern than they do in the remote repo. Specifically the Ivy.xml file, which lists the jar dependencies, is in a different subdirectory from the Jar. Annoyingly Ivy fails silently on this and just assumes you have no dependencies, and copies your local jar to the ivy cache with a default ivy.xml :/

I don't really grok Ivy that well, but I wonder if some of the other ivy issues are related (such as #387) to this. Maybe other patterns should be updated to include [type] and [classifier]?

@aishfenton
Copy link
Author

@aishfenton aishfenton commented May 30, 2016

Hmm, I assume those travis build fails are not related to my PR? I can't think how this change would result in some combinations of Scala and JDK not passing, but others passing fine.

Also I didn't include a unit test because I wasn't sure how you'd do it (you need another project to have "sbt publishLocal" first), but open to suggestions?

@lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jun 2, 2016

Looks good to me; the test failures are probably flakes. No need for unit tests here

@lihaoyi lihaoyi merged commit 7687c11 into com-lihaoyi:master Jun 2, 2016
1 of 2 checks passed
@lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jun 2, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants