-
-
Notifications
You must be signed in to change notification settings - Fork 372
Fix compiler plugin instance duplication #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I deleted the test since it was obviously bogus (since there is no way to specify classifiers like |
I don't understand; if it fixes your issue, can't you put the console trace of your issue-repro in the test? |
@lihaoyi oh, I didn't realise that loading the |
Whaaaat. The JVM crashed. I'm not sure that's my fault. Can you trigger a rebuild? |
ah sure lemme do that when i get back to my computer On Wednesday, 7 September 2016, Roman Tkalenko notifications@github.com
|
@tkroman The tests pass and I can repro locally. Could you explain in a bit more detail why the status quo has this problem, and why this fixes it? It's not clear to me reading the code |
When you load the macro-paradise plugin, 2 jars containing the To be completely honest, I'm looking at all this stuff from a beginner's point of view. I just did what seemed logical after reading the code where the exception happened. The only guess I had to do was about having more than one jar on the classpath, and that's easily checked with the debugger. |
Ok sounds reasonable, thanks! |
@tkroman This is available in the latest unstable version COMMIT-849e5e7 http://www.lihaoyi.com/Ammonite/#UnstableVersions |
@lihaoyi awesome, thanks! |
Which was caused by the presence of both normal and source jars on the classpath and led to behaviour like this: