add beforeExitHooks for cleanup before repl exits #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanresusername
force-pushed
the
before-exit
branch
from
ba79f86 to
0914bae
Compare
|
I'm also seeing issues in the Travis Scala 2.10.6 build and I don't understand the error at all. Maybe this build is flaky? |
|
yeah, i was getting something about a |
|
Yeah that's just a flake; we can ignore it, unless you want to dig into why it's happening (I haven't had the time to) |
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by #121 but not exactly what we were discussing there
not sure if this is the best (or even a good 😅 ) way to do this
but really just wanted something that worked like this and this handled that usecase well enough for me :)
glad to hear other thoughts/suggestions/improvements/etc