Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for Ammonite does not properly backtick a value #663 #668

Merged
merged 3 commits into from Jul 20, 2017

Conversation

@justinhj
Copy link
Contributor

@justinhj justinhj commented Jul 19, 2017

works

@lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jul 19, 2017

Looks good. Three things to do before landing:

@ val `//` = 1
cmd2.sc:77: ')' expected but '}' found.
      ) }
        ^
Compilation Failed
@justinhj
Copy link
Contributor Author

@justinhj justinhj commented Jul 19, 2017

Cool will address these issues

@ `// and then`
res16: Int = 123
@ import ` `.{` ` => `/*`}

This comment has been minimized.

@lihaoyi

lihaoyi Jul 19, 2017
Member

Could you convert one of these to

val `/*` = 123

Just to make sure that works too

@justinhj
Copy link
Contributor Author

@justinhj justinhj commented Jul 19, 2017

@lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jul 20, 2017

Yeah I know you have tests for /*, I want you to also explicitly test the

val `/*` = ...

syntax because it fails with a different error than the import command, and we should make sure that the val assignment works

@justinhj
Copy link
Contributor Author

@justinhj justinhj commented Jul 20, 2017

Ah i see, will do

@lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jul 20, 2017

Looks good, thanks!

@lihaoyi lihaoyi merged commit 5091a87 into com-lihaoyi:master Jul 20, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jul 20, 2017

Fixed in #663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants