Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes dependency on scalaz (#644) #830

Merged
merged 3 commits into from Jul 4, 2018

Conversation

@anowak
Copy link
Contributor

@anowak anowak commented Jun 22, 2018

Coursier no longer depends on scalaz as of 1.1.0-M4. Removing scalaz
means smaller bundle size and keeping interpreter classpath more
pristine.

Coursier no longer depends on scalaz as of 1.1.0-M4. Removing scalaz
means smaller bundle size and keeping interpreter classpath more
pristine.
'values - check212(load(instance.values _), "Map.scala", "def values")
'mapAccumL - check212(load(instance.mapAccumL _), "Map.scala", "def mapAccumL")
'split - check212(load(instance.split _), "Map.scala", "def split")
}

This comment has been minimized.

@alexarchambault

alexarchambault Jun 22, 2018
Collaborator

These tests could probably be kept by adding a dependency on scalaz, in the repl module, only in tests.

@lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jun 23, 2018

I'm fine with whatever, either merging this now or waiting for 1.1.0-FINAL. @alexarchambault feel free to merge (or not) at your leisure

@anowak
Copy link
Contributor Author

@anowak anowak commented Jun 25, 2018

I need to admit that I ran tests only on Scala 2.11.9 locally.

It would seem that the line introduced by the latest change is redundant. I'm not sure why it makes it work on 2.12.

@alexarchambault
Copy link
Collaborator

@alexarchambault alexarchambault commented Jul 3, 2018

@lihaoyi Do you have an opinion about 7104f12 (#830 (comment))? I'm ok to merge else.

@lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jul 4, 2018

@alexarchambault Let's just leave it in for now, can't do any harm

@lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jul 4, 2018

go ahead and merge :)

@alexarchambault alexarchambault merged commit e9dee62 into com-lihaoyi:master Jul 4, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@anowak anowak deleted the evidenceprime:issue-644 branch Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants