Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jline autocomplete #846

Merged
merged 2 commits into from Aug 10, 2018
Merged

Fix jline autocomplete #846

merged 2 commits into from Aug 10, 2018

Conversation

@sake92
Copy link
Collaborator

@sake92 sake92 commented Aug 9, 2018

Fixes #817, #823.
Cursor now behaves correctly. Please report if there are still issues with it.
I still couldn't figure out why it doesn't accept a candidate when there are braces at the end (assume | is cursor): x.toSt|() (but it stays there now.. xD).

When you hit Enter now, it will only accept the input when cursor is at the end.

There's also a fix in FrontEndUtils for width and height, I forgot when the exception was happening...

@lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Aug 10, 2018

looks good to me, gave you commit access so merge whenever you're happy

@sake92
Copy link
Collaborator Author

@sake92 sake92 commented Aug 10, 2018

Thank you @lihaoyi! It means a lot to me. 😃

@sake92 sake92 merged commit e09d900 into com-lihaoyi:master Aug 10, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants