Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete import $ivy too #957

Merged

Conversation

alexarchambault
Copy link
Collaborator

No description provided.

@alexarchambault
Copy link
Collaborator Author

Result:
complete-dependencies

@lihaoyi
Copy link
Member

lihaoyi commented May 2, 2019

lgtm ship it

@alexarchambault alexarchambault merged commit 7e89968 into com-lihaoyi:master May 2, 2019
@alexarchambault alexarchambault deleted the tweak-completion branch May 2, 2019 13:07
tgodzik pushed a commit to scalameta/metals that referenced this pull request Sep 14, 2022
Hi, I've been playing around with Ammonite ivy import completions in metals (heavily inspired by com-lihaoyi/Ammonite#957) using the awesome coursier api, demo:

It works very similarly to the existing completions for `$file`s, essentially we just ask `coursierapi.Complete` for completions.  Additionally, when we're at `import $ivy.|` we return a snippet to handle backticks, and when we're at `group:|` we make sure to get scala verion-specific (e.g. `%%`) completions also (hopefully these are both clear from the video).

If you're all happy with this, I'd prefer to work incrementally on the above so as not to make one huge PR 🙂 .  Anyway, let me know what you think, thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants