From 15a24ec7f25262f1995c817a35a02829095c8ca3 Mon Sep 17 00:00:00 2001 From: Tobias Roeser Date: Sat, 18 Feb 2023 23:38:54 +0100 Subject: [PATCH 1/2] `ScalaJSModule`: Deprecate `fastOpt` and `fullOpt` --- scalajslib/src/mill/scalajslib/ScalaJSModule.scala | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scalajslib/src/mill/scalajslib/ScalaJSModule.scala b/scalajslib/src/mill/scalajslib/ScalaJSModule.scala index abe4a56b20b..48af2a73839 100644 --- a/scalajslib/src/mill/scalajslib/ScalaJSModule.scala +++ b/scalajslib/src/mill/scalajslib/ScalaJSModule.scala @@ -92,10 +92,12 @@ trait ScalaJSModule extends scalalib.ScalaModule { outer => linkTask(isFullLinkJS = true, forceOutJs = false)() } + @deprecated("Use fastLinkJS instead", "Mill after 0.10.11") def fastOpt: Target[PathRef] = T { getReportMainFilePathRef(linkTask(isFullLinkJS = false, forceOutJs = true)()) } + @deprecated("Use fullLinkJS instead", "Mill after 0.10.11") def fullOpt: Target[PathRef] = T { getReportMainFilePathRef(linkTask(isFullLinkJS = true, forceOutJs = true)()) } From 08b72dbaec40686d74b375859f629e7bb86062d8 Mon Sep 17 00:00:00 2001 From: Tobias Roeser Date: Thu, 30 Mar 2023 08:21:13 +0200 Subject: [PATCH 2/2] Apply suggestions from code review Update deprecated version --- scalajslib/src/mill/scalajslib/ScalaJSModule.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scalajslib/src/mill/scalajslib/ScalaJSModule.scala b/scalajslib/src/mill/scalajslib/ScalaJSModule.scala index 48af2a73839..05ccc944826 100644 --- a/scalajslib/src/mill/scalajslib/ScalaJSModule.scala +++ b/scalajslib/src/mill/scalajslib/ScalaJSModule.scala @@ -92,12 +92,12 @@ trait ScalaJSModule extends scalalib.ScalaModule { outer => linkTask(isFullLinkJS = true, forceOutJs = false)() } - @deprecated("Use fastLinkJS instead", "Mill after 0.10.11") + @deprecated("Use fastLinkJS instead", "Mill 0.10.12") def fastOpt: Target[PathRef] = T { getReportMainFilePathRef(linkTask(isFullLinkJS = false, forceOutJs = true)()) } - @deprecated("Use fullLinkJS instead", "Mill after 0.10.11") + @deprecated("Use fullLinkJS instead", "Mill 0.10.12") def fullOpt: Target[PathRef] = T { getReportMainFilePathRef(linkTask(isFullLinkJS = true, forceOutJs = true)()) }