Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Java client does not terminate gracefully anymore #409
In previous versions of CometD and Jetty websocket, the default thread pools of the long polling and websocket transports were started as daemon threads. Not anymore. Now my java client cannot terminate gracefully anymore.
I think, by default the thread pools should still be created as daemon threads. If there are good reasons not to do so, I'd propose one of the following options:
I had posted the issue on the mailing list: https://groups.google.com/d/msg/cometd-users/7agxLpVthuE/4AJlhFfyZAgJ
sbordet on 2013-02-19T06:50:11Z:
I agree with you that default pools needs to be daemon since you can't configure them explicitly.
However, it is unclear to me what exact version of CometD you're using.
fdummert on 2013-02-19T07:26:04Z:
I still think, that WebSocketClient should get a setScheduler.
And what about c), this could still be a handy utility method?