New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of messages in handshake reply #734

Closed
sbordet opened this Issue Aug 16, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@sbordet
Member

sbordet commented Aug 16, 2017

Following #604, the ack extension now has a size field that tells how many messages needs to be processed.

However, if an application has a QueueListener and modifies the number of messages to process, then this number could be wrong.

@sbordet

This comment has been minimized.

Show comment
Hide comment
@sbordet

sbordet Aug 16, 2017

Member

Need to verify that the solution works with fully async CometD 4.0 as well.

Member

sbordet commented Aug 16, 2017

Need to verify that the solution works with fully async CometD 4.0 as well.

@sbordet sbordet closed this in 7e9d856 Oct 13, 2017

sbordet added a commit that referenced this issue Oct 18, 2017

Issue #734 - Handling of messages in handshake reply.
Modified handling of the allowMessagesDuringHandshake property:
now the value is copied to new sessions so that applications can
enable on a per-session basis when it's disabled for the transport,
and disable on a per-session basis when it's enabled for the transport.

@sbordet sbordet added this to the 3.1.3 milestone Oct 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment