New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angular-cometd does not work with angular 1.6.x #756

Closed
panakran opened this Issue Nov 30, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@panakran

panakran commented Nov 30, 2017

angular-cometd uses success/error instad of then.

Replacing with then() and passing data.data to onSuccess() instead of data solves the issue.

@sbordet

This comment has been minimized.

Show comment
Hide comment
@sbordet

sbordet Dec 1, 2017

Member

Can you please be more specific ? The Angular Demo works fine for me, so I'm not sure where the problem is.

Member

sbordet commented Dec 1, 2017

Can you please be more specific ? The Angular Demo works fine for me, so I'm not sure where the problem is.

@panakran

This comment has been minimized.

Show comment
Hide comment
@panakran

panakran Dec 2, 2017

I am referring to this https://code.angularjs.org/1.5.10/docs/api/ng/service/$http#deprecation-notice
AngularJs examples use version 1.5.8, latest angularjs version is 1.6.x

panakran commented Dec 2, 2017

I am referring to this https://code.angularjs.org/1.5.10/docs/api/ng/service/$http#deprecation-notice
AngularJs examples use version 1.5.8, latest angularjs version is 1.6.x

@sbordet

This comment has been minimized.

Show comment
Hide comment
@sbordet

sbordet Dec 2, 2017

Member

Ah, thanks. I will upgrade Angular.

Member

sbordet commented Dec 2, 2017

Ah, thanks. I will upgrade Angular.

@sbordet sbordet changed the title from angular-cometd does not work with latest versions of angular 1.x to angular-cometd does not work with angular 1.6.x Jan 12, 2018

@sbordet sbordet closed this in efd0c6c Jan 12, 2018

@sbordet sbordet added this to the 3.1.4 milestone Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment