Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Java Bayeux Client can send a disconnect message without a clientId #777
I've noticed that it's possible for the Java Bayeux Client to send a
According to the protocol documentation, a
Steps to Reproduce
Looking at the code, it's currently legal for the client to transition directly from
I wonder if transitioning from
Alternatively, maybe the
What CometD version are you using ?
That is considered bad API usage.
Not sending the disconnect message is IMO worse than sending one without the
I don't understand if you are reporting this because it actually causes you a problem, or just for sake of precision with respect to the specification.
hi @sbordet – thanks for the quick reply :)
I'm writing a basic (long-polling) Bayeux client for a different platform and have been studying how the cometd client handles some edge cases (in an effort to keep my client relatively consistent).
I hadn't considered the connection-aware transport since my client is currently long-polling only.
My example above is clearly contrived, but I think it's a valid use case for an application to want to stop the client (via
I'm not sure what the expected / defined behavior of the Bayeux Server is if a client sends a
Really appreciate the help!
CometD API were designed a while ago, and today's design may be different and more up-to-date with current technologies and patterns.
So if you're designing new APIs, maybe you want to make sure that
Regarding the case at hand, I don't think the server should disconnect all sessions for a particular
We may indeed avoid to send the disconnect message, though - it will have the same effect (client disconnected and server timing out the session).