Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Extension return value #855

Open
sbordet opened this issue Apr 20, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@sbordet
Copy link
Member

commented Apr 20, 2019

Extensions, in both client and server, are currently returning a boolean value.

However, the semantic is slightly more convoluted than a simple boolean: we want to be able to deny the message (and stop processing of other extensions), to ignore the message (and continue processing of other extensions), accept the message and perhaps drop the message (i.e. don't deny it but also don't continue the processing).

This is now partially achieved on the server using the boolean return value and the handled feature in ServerMessageImpl that however is not surfaced in the APIs.

We would to validate if boolean + handled is enough as a general semantic, and see whether it could be applied to the client too.

The alternative could be to use an enum value, but that would be a breaking change.

@sbordet sbordet added the enhancement label Apr 20, 2019

@sbordet sbordet added this to the 5.0.0 milestone Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.