Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for site_aliases #164

Merged
merged 1 commit into from Mar 24, 2012
Merged

Option for site_aliases #164

merged 1 commit into from Mar 24, 2012

Conversation

holli
Copy link
Contributor

@holli holli commented Mar 18, 2012

We have our site at domain.com, but in development and testing I'm using localhost.inv. Other developer uses something like domain.lvh.me.

This patch adds following config option.

config.site_aliases =  [['domain.com', 'localhost.inv', 'domain.lvh.me'], ['domain.fi', 'localhost.fi.inv']]

In db we have site marked as "domain.com" in all databases, both production and development/testing.

Other option would be to add fixtures to be loaded according to own domains but this approach feels much more nicer as everybody has the same database infos.

GBH pushed a commit that referenced this pull request Mar 24, 2012
@GBH GBH merged commit fac672f into comfy:master Mar 24, 2012
@GBH
Copy link
Member

GBH commented Mar 24, 2012

Thanks, this is something I encountered many times, but I just told other devs to suck it up and have same dev hosts :)

@GBH
Copy link
Member

GBH commented Mar 24, 2012

I changed how it looks a bit though:

ComfortableMexicanSofa.config.hostname_aliases = {
  'test.host'   => 'alias_a.host',
  'test2.host'  => %w(alias_b.host alias_c.host)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants