Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The API schema is invalid #1132

Closed
jmsmkn opened this issue Jan 30, 2020 · 3 comments · Fixed by #1737
Closed

The API schema is invalid #1132

jmsmkn opened this issue Jan 30, 2020 · 3 comments · Fixed by #1737

Comments

@jmsmkn
Copy link
Member

jmsmkn commented Jan 30, 2020

Go to https://grand-challenge.org/api/ and at the very far bottom right there is a validate button. Click on it, it returns:

{"schemaValidationMessages":[{"level":"error","domain":"validation","keyword":"additionalProperties","message":"object instance has properties which are not allowed by the schema: [\"$schema\",\"anyOf\",\"definitions\"]","schema":{"loadingURI":"http://swagger.io/v2/schema.json#","pointer":"/definitions/schema"},"instance":{"pointer":"/definitions/Answer/properties/answer"}}]}
@jmsmkn
Copy link
Member Author

jmsmkn commented Jan 30, 2020

@silvandeleemput do you know why this is? We should fix it before integrating elsewhere.

@silvandeleemput
Copy link
Member

@jmsmkn It appears to be related to the new Answertype schema, but I don't know why yet. I am looking into it.

@silvandeleemput
Copy link
Member

The external validation (https://validator.swagger.io/) of our served schema is not Swagger 2.0 compliant. This is because the served Answertype schema has certain unexpected properties (nested definitions, schema definitions, and anyOf keyword), With OpenAPI 3. 0 on the horizon, we might want to move to this more feature-complete formatting.

https://blog.readme.com/an-example-filled-guide-to-swagger-3-2/?utm_content=buffer5a042&utm_medium=social&utm_source=twitter.com&utm_campaign=buffer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants