feat: SQSMessageModel validates required fields of message#1188
Merged
Conversation
Allows us to remove the non-null assertions, making this model more type-safe. This is unlikely to break any existing applications as this model is intended for _received_ messages, which have all required fields. BREAKING CHANGE: `SQSMessageModel` will throw if required fields (`MessageID`, `ReceiptHandle`, `Body`) are missing from the SQS message.
seb-cr
changed the title
SQSMessageModel checks message has required fieldsSQSMessageModel validates required fields of message
corinja
approved these changes
Dec 11, 2023
|
🎉 This PR is included in version 2.0.0-beta.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows us to remove the non-null assertions, making this model more type-safe.
This is unlikely to break any existing applications as this model is intended for received messages, which have all required fields.
Jira: ENG-2733
BREAKING CHANGE:
SQSMessageModelwill throw if required fields (MessageID,ReceiptHandle,Body) are missing from the SQS message.