Integrate with @comicrelief/eslint-config (#83)#94
Merged
Conversation
dipasqualew
force-pushed
the
83-integrate-with-comicrelief-eslint-config
branch
from
b1d7ab0 to
9ac7758
Compare
dipasqualew
changed the title
lebaz20
reviewed
Aug 27, 2020
lebaz20
suggested changes
Aug 27, 2020
Contributor
lebaz20
left a comment
lebaz20
left a comment
There was a problem hiding this comment.
Commit messages need to trigger semantic-release process.
Contributor
|
@dipasqualew you can edit commit messages to include |
Contributor
Author
|
I don't think it's required because this change doesn't provide any new feature nor change in functionality. It's merely a dev update, so I don't think there's anything to release |
lebaz20
previously approved these changes
Aug 27, 2020
In order to not introduce regression on highly complex functions, some of the rules have been disabled, with the aim of resolving disabled rules one by one in future releases. Added the `yarn lint` command.
dipasqualew
force-pushed
the
83-integrate-with-comicrelief-eslint-config
branch
from
684c731 to
03fa011
Compare
lebaz20
approved these changes
Aug 27, 2020
Contributor
|
🎉 This PR is included in version 1.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to not introduce regression on highly complex functions, some of the rules have been disabled, with the aim of resolving disabled rules one by one in future releases.
Added the
yarn lintcommand.Closes #83