This repository has been archived by the owner on Mar 23, 2021. It is now read-only.
Add mac entitlements to fix ledger integration + app icons #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
suggested changes
Oct 9, 2020
Script only tested on Mac. Script requires several tools to be installed. Script not optimized :)
thomaseizinger
approved these changes
Oct 9, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 9, 2020
112: Add mac entitlements to fix ledger integration + app icons r=mergify[bot] a=da-kami Fix from here: node-hid/node-hid#321 Additionally use the default directory settings from electron builder to avoid confusion: https://www.electron.build/configuration/configuration Co-authored-by: Daniel Karzel <daniel@comit.network>
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix from here: node-hid/node-hid#321
Additionally use the default directory settings from electron builder to avoid confusion:
https://www.electron.build/configuration/configuration