New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more clippy lints #304

Closed
thomaseizinger opened this Issue Sep 28, 2018 · 5 comments

Comments

Projects
None yet
4 participants

@D4nte D4nte added the icebox label Nov 22, 2018

@LLFourn LLFourn added the open source label Dec 8, 2018

@LLFourn

This comment has been minimized.

Copy link
Contributor

LLFourn commented Dec 8, 2018

"open source" added to force discussion.

@D4nte

This comment has been minimized.

Copy link
Member

D4nte commented Dec 10, 2018

IMHO: agree for opensource.

@bonomat bonomat removed the open source label Dec 12, 2018

@D4nte

This comment has been minimized.

Copy link
Member

D4nte commented Dec 17, 2018

Agreed for all.
Please note, type inference does not work as well with Arc::clone() and hence we may need to deactivate the warning locally in some places.

@D4nte D4nte added groomed and removed icebox labels Dec 17, 2018

@bonomat bonomat added sprint-backlog and removed groomed labels Dec 18, 2018

@bonomat bonomat self-assigned this Dec 19, 2018

@bonomat

This comment has been minimized.

Copy link
Member

bonomat commented Dec 19, 2018

It seems like clippy does not support a proper config file right now and we need to fall back to passing extra lints as arguments ala:
clippy -- -W clippy::clone_on_ref_ptr -D warnings

More to read: rust-lang/rust-clippy#3164

@bonomat

This comment has been minimized.

Copy link
Member

bonomat commented Dec 20, 2018

I opt for not using clone_on_ref_ptr as we would need to make too many exceptions. However, we should make it best practice to use Arc::clone over .clone() where possible.

@bonomat bonomat added this to the Sprint 4 🎄🎅🏿 milestone Dec 20, 2018

@bonomat bonomat referenced this issue Jan 8, 2019

Merged

Add a few checks to clippy #625

1 of 1 task complete

@wafflebot wafflebot bot added review and removed work-in-progress labels Jan 8, 2019

@mergify mergify bot closed this in #625 Jan 9, 2019

@wafflebot wafflebot bot removed the review label Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment