Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When refund is possible... #411

Closed
D4nte opened this issue Nov 13, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@D4nte
Copy link
Member

commented Nov 13, 2018

.. the http API will return the refund actions. See #384 and #410.
Alice & Bob should be able to proceed with the refund.

Dod:

  • Implement the refund action route GET swaps/rfc003/:id/refund
  • Returns details as soon as technically possible (ie, funding has happened)
  • Return data to allow user to proceed with refund
  • Remove #allow[dead_code] here:
    #[derive(Debug, Serialize)]
    pub enum HtlcState {
    NotDeployed,
    Deployed,
    Funded,
    Redeemed,
    #[allow(dead_code)]
    Refunded,

Pre-work:

  • Decide on the data to be returned per blockchain
  • Decide on how to acquire data to build response from the state
  • Maybe do #467 first

Child of #405.
Blocked by #767.
Blocked by #576.
Blocked by #679
Blocked by #693
Blocked by comit-network/RFCs#7

@D4nte D4nte added the icebox label Nov 22, 2018

@LLFourn LLFourn referenced this issue Dec 8, 2018

Closed

BTC<->ETH #405

@bonomat bonomat removed the icebox label Dec 12, 2018

@D4nte D4nte added the icebox label Dec 16, 2018

@comit-network comit-network deleted a comment from LLFourn Jan 20, 2019

@D4nte D4nte added groomed and removed icebox labels Jan 30, 2019

@D4nte D4nte added sprint-backlog and removed groomed labels Feb 13, 2019

@D4nte D4nte added sprint-backlog and removed groomed labels Feb 27, 2019

@D4nte D4nte added sprint-backlog and removed groomed labels Mar 13, 2019

@ghost ghost assigned D4nte Mar 21, 2019

@ghost ghost added work-in-progress and removed sprint-backlog labels Mar 21, 2019

@ghost ghost added review and removed work-in-progress labels Mar 25, 2019

@D4nte D4nte added work-in-progress and removed review labels Mar 25, 2019

@bonomat bonomat referenced this issue Apr 3, 2019

Closed

Ensure comit-i supports refund #35

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.