New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering of "log" in Ethereum blocks #412

Closed
D4nte opened this Issue Nov 13, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@D4nte
Copy link
Member

D4nte commented Nov 13, 2018

Update ledger query service to add a new query parameter: log.

Note:
Log can be retrieved from the TransactionReceipt.
Matching is currently only done for transaction, see if transaction receipt can be inlined in transaction to keep code generic.
Decide on an efficient design so that receipt is only retrieved if needed.

  1. Avoid multiple http requests for the same receipt
  2. Avoid retrieve receipt if not needed. Apply filters on transaction and only if it matches, retrieve receipt and apply filters on receipt

DoD:

  • Add log filter to LQS to filter transaction with specific log
  • Only add unit test of matches method

Child of #405.

@D4nte D4nte assigned D4nte and unassigned D4nte Nov 14, 2018

@D4nte D4nte added the security label Nov 16, 2018

@D4nte D4nte added the icebox label Nov 22, 2018

@bonomat bonomat added groomed and removed icebox labels Dec 12, 2018

@D4nte D4nte removed the groomed label Dec 12, 2018

This was referenced Dec 12, 2018

@bonomat bonomat added sprint-backlog and removed groomed labels Dec 18, 2018

@bonomat bonomat added this to the Sprint 4 🎄🎅🏿 milestone Dec 20, 2018

@bonomat bonomat self-assigned this Dec 20, 2018

@D4nte D4nte removed this from the Sprint 4 🎄🎅🏿 milestone Jan 8, 2019

@bonomat bonomat added this to the Sprint 5 📜🔓 milestone Jan 9, 2019

@D4nte D4nte removed this from the Sprint 5 📜🔓 milestone Jan 15, 2019

@D4nte D4nte added review and removed work-in-progress labels Jan 15, 2019

@D4nte D4nte added this to the Sprint 6 🔄📖 milestone Jan 16, 2019

@bonomat bonomat closed this in #647 Jan 21, 2019

@wafflebot wafflebot bot removed the review label Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment