New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate secret length in ETH&ERC20 HTLC #433

Closed
D4nte opened this Issue Nov 18, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@D4nte
Copy link
Member

D4nte commented Nov 18, 2018

See #416

Use CALLDATASIZE to verify that the secret size is exactly 32 bytes.

DoD:

  • integration test with ETH
  • integration test with ERC20

Child of #399.
Child of #405.

@D4nte D4nte changed the title Validate secret length in ETH HTLC Validate secret length in ETH&ERC20 HTLC Nov 18, 2018

@D4nte D4nte added the icebox label Nov 22, 2018

@bonomat bonomat added groomed and removed icebox labels Dec 12, 2018

@D4nte D4nte added security sprint-backlog and removed groomed labels Dec 12, 2018

@D4nte D4nte added this to the Sprint 3 milestone Dec 12, 2018

@wafflebot wafflebot bot added work-in-progress and removed sprint-backlog labels Dec 18, 2018

@D4nte D4nte added the blocked label Dec 27, 2018

@D4nte

This comment has been minimized.

Copy link
Member Author

D4nte commented Dec 27, 2018

I have difficulties getting transaction trace from Parity. Best to hold it for now and work with a colleague on it.

@D4nte D4nte referenced this issue Jan 3, 2019

Merged

Check secret length in ERC20 & ETH HTLCs #612

1 of 1 task complete

@wafflebot wafflebot bot added review and removed work-in-progress labels Jan 3, 2019

@mergify mergify bot closed this in #612 Jan 8, 2019

@wafflebot wafflebot bot removed the review label Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment