New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rfc003::SecretHash implement Copy #440

Closed
thomaseizinger opened this Issue Nov 19, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@thomaseizinger
Copy link
Member

thomaseizinger commented Nov 19, 2018

Currently, the SecretHash implementation for rfc003 is not Copy because it is based on a Vec. However, we know that it is always 32 bytes since it is based on SHA256.

We should refactor it to a be represented as [u8; 32] and make it implement Copy.

Note:
It is an array but just need to derive Copy.

DoD:

  • derive Copy for SecretHash

@D4nte D4nte added the icebox label Nov 22, 2018

@D4nte D4nte added this to the Sprint 5 📜🔓 milestone Jan 9, 2019

@wafflebot wafflebot bot added work-in-progress and removed sprint-backlog labels Jan 10, 2019

@D4nte D4nte referenced this issue Jan 10, 2019

Merged

Make `SecretHash` `Copy` #635

1 of 1 task complete

@wafflebot wafflebot bot added review and removed work-in-progress labels Jan 10, 2019

@mergify mergify bot closed this in #635 Jan 10, 2019

@wafflebot wafflebot bot removed the review label Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment