Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bitcoin/ethereum/secp256k1 crates #463

Closed
thomaseizinger opened this Issue Nov 21, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@thomaseizinger
Copy link
Member

thomaseizinger commented Nov 21, 2018

At the moment we have crates like bitcoin_support and ethereum_support.

We should rename them either upon import (extern crate bitcoin_support as bitcoin) or just rename them altogether.

Would make the code much nicer to import :)

  • bitcoin::Address
  • ethereum::Address

etc.

@D4nte

This comment has been minimized.

Copy link
Member

D4nte commented Jan 16, 2019

@LLFourn & @thomaseizinger to argue it out.

@D4nte D4nte removed the icebox label Jan 16, 2019

@D4nte D4nte added groomed icebox and removed groomed icebox labels Jan 30, 2019

@thomaseizinger

This comment has been minimized.

Copy link
Member Author

thomaseizinger commented Feb 20, 2019

Superseded by #626.

@wafflebot wafflebot bot removed the groomed label Feb 20, 2019

@D4nte D4nte added this to the Sprint 9 🏝🏋️‍♀️ milestone Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.