New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use futures::stream in LQS #559

Closed
D4nte opened this Issue Dec 12, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@D4nte
Copy link
Member

D4nte commented Dec 12, 2018

Make LQS use futures stream to facilitate the async fetching of the receipt out of the stream.

Pre-work:
Keep #412 in mind.

Blocks #412

@D4nte D4nte added this to the Sprint 3 milestone Dec 12, 2018

@thomaseizinger

This comment has been minimized.

Copy link
Member

thomaseizinger commented Dec 12, 2018

I guess you mean a futures stream? Tokio only provides the executors and other infrastructure.

2nd guess: The goal is async fetching of the receipt? Then it should say async :)
You can have a stream that uses a blocking source under the hood, so that is not the same

@D4nte D4nte changed the title Use tokio stream in LQS Use futures::stream in LQS Dec 16, 2018

@bonomat bonomat self-assigned this Dec 17, 2018

@wafflebot wafflebot bot added review and removed work-in-progress labels Dec 18, 2018

@bonomat bonomat added work-in-progress and removed review labels Dec 18, 2018

@bonomat bonomat added review and removed work-in-progress labels Dec 19, 2018

@mergify mergify bot closed this in #587 Dec 20, 2018

@wafflebot wafflebot bot removed the review label Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment