New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ Evaluate Typescript & Flow #568

Closed
D4nte opened this Issue Dec 13, 2018 · 8 comments

Comments

Projects
None yet
5 participants
@D4nte
Copy link
Member

D4nte commented Dec 13, 2018

Look at TypeScript & Flow and see whether it would be worth migration e2e suite to one of them.

DoD:

  • Present Pro/Cons of each, especially in terms of interacting with existing blockchain libraries.

@D4nte D4nte added the testing label Dec 13, 2018

@thomaseizinger

This comment has been minimized.

Copy link
Member

thomaseizinger commented Dec 13, 2018

@D4nte D4nte changed the title Evaluate Typescript Evaluate Typescript & Flow Dec 16, 2018

@D4nte D4nte changed the title Evaluate Typescript & Flow ⚗️ Evaluate Typescript & Flow Dec 17, 2018

@bonomat bonomat added sprint-backlog and removed groomed labels Dec 18, 2018

@bonomat bonomat added this to the Sprint 4 🎄🎅🏿 milestone Dec 20, 2018

@D4nte D4nte self-assigned this Jan 4, 2019

@D4nte

This comment has been minimized.

Copy link
Member Author

D4nte commented Jan 4, 2019

Recommendation: TypeScript

From my research, it seems that TypeScript and Flow are extremely similar. Both are mature and have a number of tools and features available. Both can be easily used with Node.js.
At an earlier stage, there was notable differences between Flow and TS but the gap is now reduced and they are pretty much the same. The differences between both are not important to us.

It is easier to migrate a large project to Flow. But our project is not large.

The only notable difference in our use case is that TypeScript types definitions are available for web3.js but not the Flow ones.
The Flow types definition should be done at some point but the related issue as been closed with a SOON comment.

Both Flow and TypeScript types are available for bitcoinjs-lib

For this unique reason, I suggest we adopt TypeScript.

@D4nte D4nte added review and removed work-in-progress labels Jan 4, 2019

@D4nte

This comment has been minimized.

Copy link
Member Author

D4nte commented Jan 4, 2019

@comit-network/rust-devs let me know if you are satisfied with the research or prefer me to proceed with a PoC.

@LLFourn

This comment has been minimized.

Copy link
Contributor

LLFourn commented Jan 13, 2019

conclusion sounds good!

@thomaseizinger

This comment has been minimized.

Copy link
Member

thomaseizinger commented Jan 14, 2019

I really like the way you presented the results and I am happy with the conclusion :)

@luckysori

This comment has been minimized.

Copy link
Contributor

luckysori commented Jan 14, 2019

Colour me satisfied, good work!

@D4nte

This comment has been minimized.

Copy link
Member Author

D4nte commented Jan 14, 2019

#642 opened.

@D4nte D4nte closed this Jan 14, 2019

@wafflebot wafflebot bot removed the review label Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment