New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split test_lib.js #575

Closed
D4nte opened this Issue Dec 16, 2018 · 3 comments

Comments

Projects
None yet
5 participants
@D4nte
Copy link
Member

D4nte commented Dec 16, 2018

Split the test_lib.js in topic files:

  • Ethereum wallet
  • Bitcoin wallet
  • Comit Node Conf
  • LQS Conf

Note:
Keep in mind that we may want to re-use these libraries for a proper client/GUI

@elpiel

This comment has been minimized.

Copy link
Contributor

elpiel commented Dec 31, 2018

I want to pick this up if possible. I started separating them, but not sure how exactly it's required to split them.
For example: should the WalletConf be split in such a way that btc and eth have their own implementation of the Wallet and then the CommitConf should have 2 wallets instantiated there?

@bonomat

This comment has been minimized.

Copy link
Member

bonomat commented Jan 2, 2019

Hey @elpiel,

happy new year and thanks for your interest in contributing to COMIT :)

Regarding your question: the idea is that the file test_lib.js is split up according different functionalities, i.e.

  • a file for ethereum wallet
  • a file for bitcoin wallet
  • a file for COMIT node conf
  • a file for lqs (LedgerQueryService) conf

Note: it can be that it makes sense to split it up even more :)

@D4nte

This comment has been minimized.

Copy link
Member Author

D4nte commented Jan 2, 2019

@elpiel so yes, one for Bitcoin wallet and one for Ethereum Wallet.

@elpiel elpiel referenced this issue Jan 3, 2019

Merged

Issue #575 split test_lib.js #613

8 of 9 tasks complete

@D4nte D4nte added review and removed work-in-progress labels Jan 7, 2019

@LLFourn LLFourn closed this in #613 Jan 10, 2019

LLFourn added a commit that referenced this issue Jan 10, 2019

@wafflebot wafflebot bot removed the review label Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment