New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo make `js-format` task does not work in Travis #628

Closed
D4nte opened this Issue Jan 8, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@D4nte
Copy link
Member

D4nte commented Jan 8, 2019

The task checks git diff files (example taken from prettier website).

In Travis, there is no git changes! Hence the js-format checks nothing.

Need to implement another way to list the JavaScript files to check (find ?).

DoD:

  • All JS files are format checked (or formatted(
  • Works on Mac Os and Linux (if you use find)

@D4nte D4nte added the sprint-backlog label Jan 8, 2019

@D4nte D4nte added this to the Sprint 5 📜🔓 milestone Jan 9, 2019

@wafflebot wafflebot bot added work-in-progress and removed sprint-backlog labels Jan 10, 2019

@D4nte D4nte referenced this issue Jan 10, 2019

Merged

Format all JavaScript files #632

1 of 1 task complete

@D4nte D4nte added review and removed work-in-progress labels Jan 10, 2019

@mergify mergify bot closed this in #632 Jan 11, 2019

@wafflebot wafflebot bot removed the review label Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment