New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a better way for handling mergify #641

Closed
thomaseizinger opened this Issue Jan 14, 2019 · 7 comments

Comments

Projects
None yet
3 participants
@thomaseizinger
Copy link
Member

thomaseizinger commented Jan 14, 2019

Currently, there is a mergify rule that checks for a selected checkbox with the label Ready to merge to actually trigger the automatic merging:

- "body~=.*- [[]x[]] RTM.*"

I'd consider this to be a hack around the way it is supposed to work and would like to find a way on how we not have to rely on this.

As far as I understand, the problem is that without a label "work-in-progress", mergify will just merge as soon as the PR is approved, even though the owner might still have some work locally that they would want to include.

Let's discuss other ways on how we can prevent this from happening :)

@D4nte

This comment has been minimized.

Copy link
Member

D4nte commented Jan 14, 2019

ready-to-merge label

@thomaseizinger

This comment has been minimized.

Copy link
Member Author

thomaseizinger commented Jan 14, 2019

Indeed, such a label would solve the problem. I wonder if there is more ergonomic way though, without an additional user interaction.

One thing would be to have a time-based thing for example: Have mergify only be active at night :)

@D4nte

This comment has been minimized.

Copy link
Member

D4nte commented Jan 14, 2019

@thomaseizinger do you mind doing a separate chat with that? I have 0 opinion on the matter.
I don't think the at night thing would stop our colleagues to forget they have a "in progress" issue and that I end up approving at 10pm.

@thomaseizinger

This comment has been minimized.

Copy link
Member Author

thomaseizinger commented Jan 14, 2019

If we do a label, it would be convenient to have one that starts with a letter early in the alphabet so that is listed right at the top. Suggestions:

  • automagically-merge-this
  • approved-by-author
  • and-here-we-go
  • enable-mergify
  • ay-caramba!

@comit-network/rust-devs opinions? :)

@bonomat

This comment has been minimized.

Copy link
Member

bonomat commented Jan 14, 2019

Kribaros!
or for more ideas, check: https://www.fantasynamegenerators.com/mtg-god-names.php

@D4nte

This comment has been minimized.

Copy link
Member

D4nte commented Jan 14, 2019

automagically-mergify-this

I trust in you @thomaseizinger you have my vote

@thomaseizinger

This comment has been minimized.

Copy link
Member Author

thomaseizinger commented Jan 15, 2019

Ah, I like the name pun! I am sold :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment