New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IsEmpty trait #676

Closed
luckysori opened this Issue Jan 18, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@luckysori
Copy link
Contributor

luckysori commented Jan 18, 2019

This functionality was introduced some time ago, but it is an unnecessary optimisation that assumes that queries that match everything are undesirable. That may be the case if the ledger query service is hosted somewhere as a service, but that doesn't matter right now. Furthermore, bugs can be introduced if new fields are added to a query and the corresponding IsEmpty implementation is not updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment