New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe not print settings because of private keys?... #702

Closed
source-of-truth bot opened this Issue Jan 24, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@source-of-truth
Copy link

source-of-truth bot commented Jan 24, 2019

// TODO: Maybe not print settings because of private keys?
info!("Starting up with {:#?}", settings);

@source-of-truth

This comment has been minimized.

Copy link
Author

source-of-truth bot commented Jan 24, 2019

Closed in commit 98e54e7eee616484b3dd26c115fc913bd1940d9c pushed by @mergify[bot]

@source-of-truth source-of-truth bot closed this Jan 24, 2019

@D4nte

This comment has been minimized.

Copy link
Member

D4nte commented Jan 24, 2019

As per @LLFourn, the todo is still valid as we print out the seed.

@D4nte D4nte reopened this Jan 24, 2019

@source-of-truth

This comment has been minimized.

Copy link
Author

source-of-truth bot commented Jan 24, 2019

@thomaseizinger

This comment has been minimized.

Copy link
Member

thomaseizinger commented Jan 25, 2019

The bot is confused now @D4nte :D

Maybe we should just track it as a separate issue?

@D4nte

This comment has been minimized.

Copy link
Member

D4nte commented Jan 25, 2019

Tracked with #722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment