Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return TransactionReceipt and not Transaction. #723

Closed
source-of-truth bot opened this Issue Jan 25, 2019 · 2 comments

Comments

Projects
None yet
1 participant
@source-of-truth
Copy link

source-of-truth bot commented Jan 25, 2019

Temporarily return the transaction and not the transaction receipt as the
secret is currently only available in the transaction call data but not
in the receipt. This needs to be fixed with #638

// TODO: return TransactionReceipt and not Transaction.
// Temporarily return the transaction and not the transaction receipt as the
// secret is currently only available in the transaction call data but not
// in the receipt. This needs to be fixed with https://github.com/comit-network/comit-rs/issues/638
fn expand_result(

@D4nte D4nte added the icebox label Jan 30, 2019

@D4nte

This comment has been minimized.

Copy link
Member

D4nte commented Jan 30, 2019

To be resolved with #638

@source-of-truth

This comment has been minimized.

Copy link
Author

source-of-truth bot commented Feb 26, 2019

Closed in commit ca01617e841b741f757888e5d8d4d860ec98544d pushed by @mergify[bot]

@source-of-truth source-of-truth bot closed this Feb 26, 2019

@wafflebot wafflebot bot removed the icebox label Feb 26, 2019

@D4nte D4nte added this to the Sprint 9 🏝🏋️‍♀️ milestone Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.