Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LQS client test is not testing correctly #727

Closed
bonomat opened this Issue Jan 29, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@bonomat
Copy link
Member

bonomat commented Jan 29, 2019

The test in application/comit_node/src/ledger_query_service/client.rs should be improved as it contains outdated fields right now and the test it self does not detect it.

@D4nte

This comment has been minimized.

Copy link
Member

D4nte commented Jan 30, 2019

Related to #638

@D4nte D4nte added sprint-backlog and removed groomed labels Jan 30, 2019

@D4nte D4nte added this to the Sprint 8 👬🥚 milestone Jan 31, 2019

@D4nte D4nte self-assigned this Feb 7, 2019

D4nte added a commit that referenced this issue Feb 7, 2019

@wafflebot wafflebot bot added review and removed work-in-progress labels Feb 7, 2019

@D4nte

This comment has been minimized.

Copy link
Member

D4nte commented Feb 7, 2019

I don't think this is a valid concern. comit_node should not fail if LQS sends back unknown fields.
Allowing unknown fields gives us backward compatibility, forbidding gives us pain.

@mergify mergify bot closed this in #748 Feb 7, 2019

@wafflebot wafflebot bot removed the review label Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.