Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment and funding transactions not always available #763

Closed
luckysori opened this Issue Feb 18, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@luckysori
Copy link
Contributor

luckysori commented Feb 18, 2019

We want to store the IDs of the deployment and funding transactions, but currently LedgerEvents::htlc_deployed returns htlc_location and LedgerEvents::htlc_funded an Option<FundTransaction>.

@D4nte

This comment has been minimized.

Copy link
Member

D4nte commented Feb 19, 2019

Where do we want to store that? logs?

@luckysori

This comment has been minimized.

Copy link
Contributor Author

luckysori commented Feb 19, 2019

Where do we want to store that? logs?

The same way we store redeem and refund transactions, in the state store.

@D4nte

This comment has been minimized.

Copy link
Member

D4nte commented Feb 19, 2019

But then is the software suppose to use them?

@luckysori

This comment has been minimized.

Copy link
Contributor Author

luckysori commented Feb 19, 2019

But then is the software suppose to use them?

The intention is to return them as part of a GET /swaps/rfc003/:id request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.