Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up "WIP" for mergify/wafflebot #770

Closed
D4nte opened this Issue Feb 18, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@D4nte
Copy link
Member

D4nte commented Feb 18, 2019

Waffle bot adds "review" labels for PRs, even if they have a WIP label/in title.

With the new "draft" PR from github. We should remove "WIP in title hooks" and probably check with waffle support so that:

  • Draft PR stay label as "work-in-progress"
  • Normal PR are labelled "review"

The "automagically-merge-this" label behaviour should remain unchanged.

@thomaseizinger

This comment has been minimized.

Copy link
Member

thomaseizinger commented Feb 21, 2019

You moved this to "review" because of #780 but that is now merged. However, this is apparently blocked by waffleio/waffle.io#3832?

Please make up your mind :)

@D4nte

This comment has been minimized.

Copy link
Member Author

D4nte commented Feb 21, 2019

Well, I don't consider it blocked :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.