Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish swap response in HTTP API #775

Closed
thomaseizinger opened this Issue Feb 19, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@thomaseizinger
Copy link
Member

thomaseizinger commented Feb 19, 2019

I came across the spec (#497 (comment)) of the swap response again and noticed two minor mis-alignments.

  1. The name state.outcome property doesn't really make sense for the variant IN_PROGRESS.
    I propose renaming it to status and actually moving it one layer up. This makes more sense IMO since it describes an overall property of the swap, similar to role.

  2. The property swap is kind of redundant. Since the whole response is about a single swap. Different names could be:

  • details
  • parameters
  • ???
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.