Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /swaps/rfc003/:id does not return transaction IDs #777

Closed
luckysori opened this Issue Feb 19, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@luckysori
Copy link
Contributor

luckysori commented Feb 19, 2019

GET /swaps/rfc003/:id should return transactions IDs but is instead returning transaction objects. This could be solved in several ways:

  1. Storing Ledger::TxIds instead of Ledger::Transactions in the storage layer.
  2. Implementing the serialization of these transactions so that it returns the transaction ID.
  3. Implementing Into<TxId> for Transaction for all (Transaction, TxId) pairs and adding the corresponding trait bound on the Ledger trait.
@D4nte

This comment has been minimized.

Copy link
Member

D4nte commented Feb 19, 2019

Shouldn't this be blocked on #763 ?

@thomaseizinger

This comment has been minimized.

Copy link
Member

thomaseizinger commented Feb 20, 2019

Shouldn't this be blocked on #763 ?

For the TX that are already returned it is not blocked and a solution very likely will just work for the others once #763 is resolved.

@D4nte D4nte added the groomed label Feb 20, 2019

@luckysori luckysori referenced this issue Feb 20, 2019

Open

Missing HTTP API tests #766

0 of 2 tasks complete

@luckysori luckysori self-assigned this Feb 22, 2019

@D4nte D4nte added work-in-progress and removed groomed labels Feb 24, 2019

@wafflebot wafflebot bot added review and removed work-in-progress labels Feb 25, 2019

@luckysori

This comment has been minimized.

Copy link
Contributor Author

luckysori commented Feb 25, 2019

Resolved with #785.

@luckysori luckysori closed this Feb 25, 2019

@wafflebot wafflebot bot removed the review label Feb 25, 2019

@D4nte D4nte added this to the Sprint 9 🏝🏋️‍♀️ milestone Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.