New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testcontainers to use parity 2.1.3 across the board #617

Merged
merged 2 commits into from Jan 16, 2019

Conversation

@D4nte
Copy link
Member

D4nte commented Jan 4, 2019

testcontainers was updated to default to parity 2.1.3 and bitcoind 0.17.0.
Updating comit-rs to use latest testcontainers version.

@wafflebot wafflebot bot assigned D4nte Jan 4, 2019

@wafflebot wafflebot bot added the review label Jan 4, 2019

@D4nte D4nte requested a review from comit-network/rust-devs Jan 4, 2019

Show resolved Hide resolved Makefile.toml Outdated

@D4nte D4nte added this to the Sprint 4 🎄🎅🏿 milestone Jan 7, 2019

@D4nte D4nte requested a review from comit-network/rust-devs Jan 7, 2019

@D4nte D4nte added the blocked label Jan 7, 2019

@D4nte

This comment has been minimized.

Copy link
Member Author

D4nte commented Jan 7, 2019

Blocked as team wants to do testcontainers/testcontainers-rs#46 first

@D4nte

This comment has been minimized.

Copy link
Member Author

D4nte commented Jan 9, 2019

Blocked on publishing new version of tc_parity_parity crate to crates.io

@thomaseizinger

This comment has been minimized.

Copy link
Member

thomaseizinger commented Jan 11, 2019

I think we could just remove the whole cargo-make task and let the images download on-demand? Feels bad to maintain things like that in two different places.

@bonomat

This comment has been minimized.

Copy link
Member

bonomat commented Jan 11, 2019

I think we could just remove the whole cargo-make task and let the images download on-demand? Feels bad to maintain things like that in two different places.

Good point. However, this will have the effect that tests will run arbitrarily long sometimes as an image might be downloaded.

@D4nte

This comment has been minimized.

Copy link
Member Author

D4nte commented Jan 11, 2019

@bonomat the image would be downloaded in any case and we currently do not look at single test performance.
What is good in downloading the images at the beginning is to fail fast in case of outage of docker.io (which do happen).

@thomaseizinger

This comment has been minimized.

Copy link
Member

thomaseizinger commented Jan 14, 2019

But is that enough to justify the duplication? I am not sure.

@D4nte

This comment has been minimized.

Copy link
Member Author

D4nte commented Jan 14, 2019

Didn't you add it in the first place @thomaseizinger ? :)

@thomaseizinger

This comment has been minimized.

Copy link
Member

thomaseizinger commented Jan 14, 2019

I did but I am starting to regret it as it seems to be a maintenance burden to keep it in sync with what is actually used.

@D4nte D4nte added review and removed review labels Jan 14, 2019

@D4nte D4nte force-pushed the docker-pull branch 2 times, most recently from 73a3759 to 3be0ff0 Jan 15, 2019

@D4nte D4nte removed this from the Sprint 4 🎄🎅🏿 milestone Jan 15, 2019

@D4nte D4nte removed the blocked label Jan 15, 2019

@D4nte D4nte changed the title Add all docker images that are actually used Update testcontainers to use parity 2.1.3 across the board Jan 16, 2019

@D4nte D4nte force-pushed the docker-pull branch from 3be0ff0 to 3ca5369 Jan 16, 2019

@mergify mergify bot merged commit d918e5a into master Jan 16, 2019

1 check passed

license/cla Contributor License Agreement is signed.
Details

@wafflebot wafflebot bot removed the review label Jan 16, 2019

@mergify mergify bot deleted the docker-pull branch Jan 16, 2019

@D4nte D4nte added this to the Sprint 6 🔄📖 milestone Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment