Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate testcontainers to use parity 2.1.3 across the board #617
Conversation
wafflebot
bot
assigned
D4nte
Jan 4, 2019
wafflebot
bot
added
the
review
label
Jan 4, 2019
D4nte
requested a review
from comit-network/rust-devs
Jan 4, 2019
bonomat
reviewed
Jan 5, 2019
Makefile.toml Outdated
D4nte
added this to the Sprint 4 🎄🎅🏿 milestone
Jan 7, 2019
D4nte
added
the
added-mid-sprint
label
Jan 7, 2019
D4nte
requested a review
from comit-network/rust-devs
Jan 7, 2019
D4nte
added
the
blocked
label
Jan 7, 2019
This comment has been minimized.
This comment has been minimized.
Blocked as team wants to do testcontainers/testcontainers-rs#46 first |
This comment has been minimized.
This comment has been minimized.
Blocked on publishing new version of |
This comment has been minimized.
This comment has been minimized.
I think we could just remove the whole |
This comment has been minimized.
This comment has been minimized.
Good point. However, this will have the effect that tests will run arbitrarily long sometimes as an image might be downloaded. |
This comment has been minimized.
This comment has been minimized.
@bonomat the image would be downloaded in any case and we currently do not look at single test performance. |
This comment has been minimized.
This comment has been minimized.
But is that enough to justify the duplication? I am not sure. |
This comment has been minimized.
This comment has been minimized.
Didn't you add it in the first place @thomaseizinger ? :) |
This comment has been minimized.
This comment has been minimized.
I did but I am starting to regret it as it seems to be a maintenance burden to keep it in sync with what is actually used. |
D4nte commentedJan 4, 2019
•
edited
testcontainers was updated to default to parity 2.1.3 and bitcoind 0.17.0.
Updating comit-rs to use latest testcontainers version.